Remove Hash and Eq from AstNodeRef for types not implementing Eq or Hash
#16100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
requested review from
AlexWaygood,
carljm and
sharkdp
as code owners
MichaReiser
added
internal
carljm
approved these changes
Feb 11, 2025
Contributor
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Looks good, modulo the one inline question.
To be clear, my comment wasn't intended to suggest that I think it's important we make this change; I was just curious what the tradeoffs are and if there was anything we should document for future.
Member
Author
|
Hmm, it does seem that this regresses performance slightly (2%) for the cold case. Let me re-run to verify that it is real. It might just be the cost of tracking the |
dcreager
added a commit
that referenced
this pull request
Feb 11, 2025
* main: add diagnostic `Span` (couples `File` and `TextRange`) (#16101) Remove `Hash` and `Eq` from `AstNodeRef` for types not implementing `Eq` or `Hash` (#16100) Fix release build warning about unused todo type message (#16102) [`pydocstyle`] Handle arguments with the same names as sections (`D417`) (#16011) [red-knot] Reduce usage of `From<Type>` implementations when working with `Symbol`s (#16076) Transition to salsa coarse-grained tracked structs (#15763) [`pyupgrade`] Handle micro version numbers correctly (`UP036`) (#16091) [red-knot] `T | object == object` (#16088) [`ruff`] Skip singleton starred expressions for `incorrectly-parenthesized-tuple-in-subscript` (`RUF031`) (#16083) Delete left-over `verbosity.rs (#16081) [red-knot] User-level configuration (#16021) Add `user_configuration_directory` to `System` (#16020)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow up to #15763 (comment)
It reverts the change to using ptr equality for
AstNodeRefs, which in turn removes theEq,PartialEq, andHashimplementations forAstNodeRefs parametrized with AST nodes.Cheap comparisons shouldn't be needed because the node field is generally marked as
[#tracked]and#[no_eq]and removing the implementations even enforces that thoseattributes are set on all
AstNodeReffields (which is good).The only downside this has is that we technically wouldn't have to mark the
Unpack::targetas#[tracked]becausethe
targetfield is accessed in every query acceptingUnpackas an argument.Overall, enforcing the use of
#[tracked]seems like a good trade off, espacially considering that it's very likely thatwe'd probably forget to mark the
Unpack::targetfield as tracked if we add a newUnpackquery that doesn't access the target.Test Plan
cargo test